Skip to content

chore(sass): minimal deprecation fixes (darken, lighten, math.div)#315

Merged
yegor256 merged 2 commits intoyegor256:masterfrom
ManiShah7:chore/fix-sass-deprecations
May 26, 2025
Merged

chore(sass): minimal deprecation fixes (darken, lighten, math.div)#315
yegor256 merged 2 commits intoyegor256:masterfrom
ManiShah7:chore/fix-sass-deprecations

Conversation

@ManiShah7
Copy link
Copy Markdown
Contributor

Description

In this PR, I’ve applied minimal fixes to remove deprecation warnings from the Sass build, specifically:

  • Replaced the deprecated darken() and lighten() functions with the new safe-adjust-lightness() wrapper
  • Fixed deprecated number / number division by replacing it with calc()

fixes #314

Notes

There are still some deprecation warning around using @import. I started exploring replacing all @import with @use, but doing that properly would require:

  • Updating all SCSS files to match new Sass module rules
  • Refactoring how variables and mixins are shared between files
  • Dropping Grunt’s sasslint since it’s incompatible with the new Sass syntax
  • Potentially replacing the Grunt-based build system with a more modern setup (like npm scripts) for easier long-term maintenance.

Let me know if you need help with this.

@yegor256
Copy link
Copy Markdown
Owner

@ManiShah7 many thanks! Can you please check why the build is broken and fix it. I will be happy to merge then.

@ManiShah7
Copy link
Copy Markdown
Contributor Author

@yegor256 apologies for that! Sure I'll fix it soon.

@ManiShah7
Copy link
Copy Markdown
Contributor Author

@yegor256 fixed!

@yegor256 yegor256 merged commit 1e50eda into yegor256:master May 26, 2025
12 checks passed
@yegor256
Copy link
Copy Markdown
Owner

@ManiShah7 thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecation warnings in CSS

2 participants